Support Log Drains #168
Merged
Support Log Drains #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d42bf43 to
9e025a0
Compare
9e025a0 to
cb36af1
Compare
cb36af1 to
8a8be59
Compare
ecklf
reviewed
Apr 19, 2024
Comment on lines
+22
to
+27
| func (v validatorMapMaxCount) Description(ctx context.Context) string { | ||
| return fmt.Sprintf("Map must contain fewer than %d items", v.Max) | ||
| } | ||
| func (v validatorMapMaxCount) MarkdownDescription(ctx context.Context) string { | ||
| return fmt.Sprintf("Map must contain fewer than %d items", v.Max) | ||
| } |
There was a problem hiding this comment.
We are doing req.ConfigValue.Elements()) > v.Max below, shouldn't it be "can't contain more than %d items"?
ecklf
reviewed
Apr 19, 2024
Comment on lines
+20
to
+25
| func (v validatorFloat64LessThan) Description(ctx context.Context) string { | ||
| return fmt.Sprintf("Value must be less than %.2f", v.Max) | ||
| } | ||
| func (v validatorFloat64LessThan) MarkdownDescription(ctx context.Context) string { | ||
| return fmt.Sprintf("Value must be less than `%.2f`", v.Max) | ||
| } |
There was a problem hiding this comment.
ecklf
reviewed
Apr 19, 2024
Comment on lines
+20
to
+25
| func (v validatorFloat64GreaterThan) Description(ctx context.Context) string { | ||
| return fmt.Sprintf("Value must be greater than %.2f", v.Min) | ||
| } | ||
| func (v validatorFloat64GreaterThan) MarkdownDescription(ctx context.Context) string { | ||
| return fmt.Sprintf("Value must be greater than `%.2f`", v.Min) | ||
| } |
There was a problem hiding this comment.
Same as here https://github.com/vercel/terraform-provider-vercel/pull/168/files#r1572629974, just with equal or greater than
ecklf
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for Customisable Log Drains (not Integration Log Drains).
Closes #128.