Fix issue updating sensitive project environment variables #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dglsparsons
commented
Mar 8, 2024
| @@ -214,7 +214,7 @@ resource "vercel_project_environment_variable" "example_git_branch" { | |||
| resource "vercel_project_environment_variable" "example_sensitive" { | |||
| project_id = vercel_project.example.id | |||
| %[3]s | |||
| key = "foo_sensitive_updated" | |||
| key = "foo_sensitive" | |||
There was a problem hiding this comment.
The test was faulty - updating the key forced a replacement, so it wasn't really testing that the other fields can be updated.
dglsparsons
commented
Mar 8, 2024
| @@ -10,7 +10,6 @@ import ( | |||
| // UpdateEnvironmentVariableRequest defines the information that needs to be passed to Vercel in order to | |||
| // update an environment variable. | |||
| type UpdateEnvironmentVariableRequest struct { | |||
| Key string `json:"key"` | |||
There was a problem hiding this comment.
Key is required-replace, so should not be present in the update request.
craigandrews
previously approved these changes
Mar 8, 2024
e7e3dd9 to
c9832f8
Compare
craigandrews
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #154