-
Notifications
You must be signed in to change notification settings - Fork 32
[vercel_team_config] Fix saml dsync for access groups #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitfoster
commented
Apr 14, 2025
jarneson
reviewed
Apr 14, 2025
dglsparsons
reviewed
Apr 25, 2025
dglsparsons
approved these changes
Apr 28, 2025
2d1784a
to
cfdd691
Compare
The tests currently have a failure, as the schema upgrade from 0 to 1 means that
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the
vercel_team_config
resource incorrectly implements Access Group support. If a team has SAML roles mapped access groups, the provider deletes the mappings.This is a breaking change
steps for upgrading 👇
vercel_team_config.saml
vercel_team_config.saml.access_group_id
is specified: remove itvercel_team_config.saml.roles
is specified: change the values of the object from strings to objects with the format{ role = "<role e.g. VIEWER>" }
|{ access_group_id = "<access_group_id>" }
terraform refresh
orterraform apply