这是indexloc提供的服务,不要输入任何密码
Skip to content

Add ability to create Deployment from git ref #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2022
Merged

Conversation

dglsparsons
Copy link
Collaborator

  • Refactor test to use env variables for repositories

@dglsparsons
Copy link
Collaborator Author

FYI @WCMinor :)

- Refactor test to use env variables for repositories
@WCMinor
Copy link
Contributor

WCMinor commented May 10, 2022

I'm testing your code, if I pass the value of ref as a hardcoded config, like in

ref     = "main"

the validation works fine. However if I pass it as a variable, as in

ref     = var.git_branch

It does not work, is throws:

A Deployment must have either `ref` or `files` specified

Of course the variable git_branch has value in my template. This is a behaviour that I found days ago, that's why I originally implemented it in the apply state (hacky).

@dglsparsons
Copy link
Collaborator Author

@WCMinor That's a good catch! I think it's because I'm checking Value rather than Null. I'll update that! :)

@dglsparsons dglsparsons requested a review from ecklf May 11, 2022 15:00
@dglsparsons dglsparsons merged commit 29d253d into main May 11, 2022
@dglsparsons dglsparsons deleted the git-deployment branch May 11, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants