Fix prebuilt deployment bugs #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were three bugs with prebuilt deployments: - The path_prefix was incorrectly trimmed before attempting to read `.vercel/output/build.json`, which led to issues reading the file. - The logic for walking the output directory did not account for the `filePathMap` field in the `vc-config.json` files for functions, which indicate which additional files should be included in the deployment. - We resolved symlinks when walking the output directory, but to prevent uploading too many of the same files over and over, we should just upload these as a symlink directly. This is doubly relevant as there are many symlinks in the `filePathMap`.
craigandrews
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were three bugs with prebuilt deployments:
.vercel/output/build.json, which led to issues reading the file.filePathMapfield in thevc-config.jsonfiles for functions, whichindicate which additional files should be included in the deployment.
uploading too many of the same files over and over, we should just
upload these as a symlink directly. This is doubly relevant as there
are many symlinks in the
filePathMap.Ref #236