这是indexloc提供的服务，不要输入任何密码
Skip to content

[firewall] fix id check in resource tests #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 30, 2025
Merged

[firewall] fix id check in resource tests #266

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fa740e
[firewall] fix id check in resource tests
sueplex Jan 30, 2025
f1dbb84
one more
sueplex Jan 30, 2025
c4143a6
fix attrcheck
sueplex Jan 30, 2025
2c82fd2
last one?
sueplex Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 43 additions & 12 deletions vercel/resource_firewall_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package vercel_test

import (
"fmt"
"strings"
"testing"

"github.com/hashicorp/terraform-plugin-testing/helper/acctest"
Expand Down Expand Up @@ -62,10 +63,15 @@ func TestAcc_FirewallConfigResource(t *testing.T) {
"vercel_firewall_config.custom",
"rules.rule.0.name",
"test"),
resource.TestCheckResourceAttr(
resource.TestCheckResourceAttrWith(
"vercel_firewall_config.custom",
"rules.rule.0.id",
"rule_test"),
func(rule_id string) error {
if !strings.HasPrefix(rule_id, "rule_test") {
return fmt.Errorf("expected id does not match got %s - expected %s", rule_id, "rule_test_...")
}
return nil
}),
resource.TestCheckResourceAttr(
"vercel_firewall_config.custom",
"rules.rule.0.action.action",
Expand All @@ -78,10 +84,15 @@ func TestAcc_FirewallConfigResource(t *testing.T) {
"vercel_firewall_config.custom",
"rules.rule.0.condition_group.0.conditions.1.value",
"POST"),
resource.TestCheckResourceAttr(
resource.TestCheckResourceAttrWith(
"vercel_firewall_config.custom",
"rules.rule.1.id",
"rule_test2"),
func(rule_id string) error {
if !strings.HasPrefix(rule_id, "rule_test2") {
return fmt.Errorf("expected id does not match got %s - expected %s", rule_id, "rule_test2_...")
}
return nil
}),
resource.TestCheckResourceAttr(
"vercel_firewall_config.custom",
"rules.rule.1.action.action",
Expand Down Expand Up @@ -110,10 +121,15 @@ func TestAcc_FirewallConfigResource(t *testing.T) {
"vercel_firewall_config.custom",
"rules.rule.1.action.rate_limit.keys.*",
"ja4"),
resource.TestCheckResourceAttr(
resource.TestCheckResourceAttrWith(
"vercel_firewall_config.custom",
"rules.rule.2.id",
"rule_test3"),
func(rule_id string) error {
if !strings.HasPrefix(rule_id, "rule_test3") {
return fmt.Errorf("expected id does not match got %s - expected %s", rule_id, "rule_test3_...")
}
return nil
}),
resource.TestCheckResourceAttr(
"vercel_firewall_config.custom",
"rules.rule.2.action.redirect.location",
Expand Down Expand Up @@ -207,10 +223,15 @@ func TestAcc_FirewallConfigResource(t *testing.T) {
"vercel_firewall_config.custom",
"rules.rule.0.name",
"test1"),
resource.TestCheckResourceAttr(
resource.TestCheckResourceAttrWith(
"vercel_firewall_config.custom",
"rules.rule.0.id",
"rule_test1"),
func(rule_id string) error {
if !strings.HasPrefix(rule_id, "rule_test1") {
return fmt.Errorf("expected id does not match got %s - expected %s", rule_id, "rule_test1_...")
}
return nil
}),
resource.TestCheckResourceAttr(
"vercel_firewall_config.custom",
"rules.rule.0.action.action",
Expand All @@ -223,10 +244,15 @@ func TestAcc_FirewallConfigResource(t *testing.T) {
"vercel_firewall_config.custom",
"rules.rule.0.condition_group.0.conditions.1.value",
"POST"),
resource.TestCheckResourceAttr(
resource.TestCheckResourceAttrWith(
"vercel_firewall_config.custom",
"rules.rule.1.id",
"rule_test2"),
func(rule_id string) error {
if !strings.HasPrefix(rule_id, "rule_test2") {
return fmt.Errorf("expected id does not match got %s - expected %s", rule_id, "rule_test2_...")
}
return nil
}),
resource.TestCheckResourceAttr(
"vercel_firewall_config.custom",
"rules.rule.1.action.action",
Expand All @@ -251,10 +277,15 @@ func TestAcc_FirewallConfigResource(t *testing.T) {
"vercel_firewall_config.custom",
"rules.rule.1.action.rate_limit.keys.*",
"ip"),
resource.TestCheckResourceAttr(
resource.TestCheckResourceAttrWith(
"vercel_firewall_config.custom",
"rules.rule.2.id",
"rule_test3"),
func(rule_id string) error {
if !strings.HasPrefix(rule_id, "rule_test3") {
return fmt.Errorf("expected id does not match got %s - expected %s", rule_id, "rule_test3_...")
}
return nil
}),
resource.TestCheckResourceAttr(
"vercel_firewall_config.custom",
"rules.rule.2.action.redirect.location",
Expand Down