这是indexloc提供的服务，不要输入任何密码
Skip to content

Remove unused SONATYPE_CLOSE_TIMEOUT_SECONDS and minor cleanups #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove unused SONATYPE_CLOSE_TIMEOUT_SECONDS and minor cleanups #1089

wants to merge 6 commits into from

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Jul 17, 2025

  • CHANGELOG's "Unreleased" section has been updated, if applicable.

@Goooler Goooler changed the title Remove unused SONATYPE_CLOSE_TIMEOUT_SECONDS and minor cleanups Remove unused SONATYPE_CLOSE_TIMEOUT_SECONDS and minor cleanups Jul 17, 2025
Goooler
Goooler commented Jul 18, 2025
View reviewed changes
central-portal/src/main/kotlin/com/vanniktech/maven/publish/portal/SonatypeCentralPortal.kt
userAgentName: String,
userAgentVersion: String,
okhttpTimeoutSeconds: Long,
private val closeTimeoutSeconds: Long,
okhttpTimeout: Duration,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, but since no users are expected to rely on it, it's safe to land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanniktech vanniktech vanniktech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Goooler @vanniktech