Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content range requests past EOF will fail witth the current version of vapor. It is common practice to just return the remaining bytes rather than throw a bad request error. This helps existing imperfect clients, still out there in the wild to continue to function.
This change captures an attempt to read past EOF (eg a range request of 10-200, when there are only 180 bytes in the file), and returns a response of "partial content" and the remaining bytes. It replaces code that returned a "bad request" error.
The existing tests have been updated to reflect this change and test for a response of type "partial content".
In addition two new asserts have been added to a test:
As well as passing all tests, the code has been tested with a real life test case.
NOTE: The test 'AsyncRouteTests.testGH2716()' does not not pass. However, it does not pass on the vapor/main branch from which this has been forked.