这是indexloc提供的服务，不要输入任何密码
Skip to content

Bump to R405 and fix SSP bugs. #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025
Merged

Bump to R405 and fix SSP bugs. #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83103f9
SSP: additional logging and 303 reporting when no ad resolved from a …
dasgarner Jan 29, 2025
6c5f5c4
SSP: strip out namespaces
dasgarner Jan 29, 2025
d886c7b
Bump to R405
dasgarner Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion Adspace/ExchangeManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,11 @@ private List<Ad> Request(Url url, Ad wrappedAd)

// Read the body of the response into XML
XmlDocument document = new XmlDocument();

// Strip out the namespace if there is one.
body = body.Replace("xmlns=\"http://www.iab.com/VAST\"", "");

// Load as XML
document.LoadXml(body);

// Expect one or more ad nodes.
Expand Down Expand Up @@ -834,6 +839,12 @@ private List<Ad> Request(Url url, Ad wrappedAd)
{
// Nothing added this time.
Trace.WriteLine(new LogMessage("ExchangeManager", "Request: No ads returned this time"), LogType.Info.ToString());

// Report a 303
if (wrappedAd != null && wrappedAd.IsWrapper)
{
ReportError(wrappedAd.ErrorUrls, 303);
}
}
}
catch (Exception e)
Expand Down Expand Up @@ -889,10 +900,16 @@ private void UnwrapAds()
ad.IsWrapperResolving = true;
adBuffet.RemoveAt(i);

LogMessage.Audit("ExchangeManager", "UnwrapAds", adBuffet.Count + " ads left in buffet");

// Make a request to unwrap this ad.
try
{
unwrappedAds.AddRange(Request(ad.AdTagUri, ad));
List<Ad> wrapAds = Request(ad.AdTagUri, ad);

LogMessage.Audit("ExchangeManager", "UnwrapAds", wrapAds.Count + " ads unwrapped from " + ad.AdTagUri);

unwrappedAds.AddRange(wrapAds);
}
catch (Exception e)
{
Expand Down
4 changes: 2 additions & 2 deletions Logic/ApplicationSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ private static readonly Lazy<ApplicationSettings>
/// </summary>
private List<string> ExcludedProperties;

public string ClientVersion { get; } = "4 R404.1";
public string ClientVersion { get; } = "4 R405.0";
public string Version { get; } = "7";
public int ClientCodeVersion { get; } = 404;
public int ClientCodeVersion { get; } = 405;

private ApplicationSettings()
{
Expand Down
4 changes: 2 additions & 2 deletions Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@
// You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("4.404.1.0")]
[assembly: AssemblyFileVersion("4.404.1.0")]
[assembly: AssemblyVersion("4.405.0.0")]
[assembly: AssemblyFileVersion("4.405.0.0")]
[assembly: Guid("3bd467a4-4ef9-466a-b156-a79c13a863f7")]