Fixed screensaver exit bugs #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit fe03a76a18444e5393b4ff25ca05c6ab6ef573db)
(cherry picked from commit 4e8b7fc40212b39a1aba3b99afa3caf8a28775b4)
…unctions. (cherry picked from commit 1d63c633d84f5be417f1bf7714d6f660754eb407)
dasgarner
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #341 and resolves #72.
Fixed the tedious bug on xibo when running as screensaver not to exit properly.
Found that some events are not de-registered (when Shutdown is called), causing unhandled exceptions (which then exits the player when running not as screensaver in the unhandled exception handler). Introduced dispose pattern for this issue.
An other bug discovered was that the app does use the window(s) as dialog but did not exit after the windows are exited.
Bonus:
Tested on WIndows 11 running v4 r404 with local build.