Fix incorrect (?) flip=True within plot_file() and plot_lines() #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Plus, I think that in but the same caveats as above apply. Maybe it's just something with my setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
plot_file()orplot_lines(),my drawings come out flipped along the x-axis. Taking a look at the code, I noticed that
plot_file()callsplot_lines()withflip=True, which seems wrong but the removal of which didn't fix my problems on its own, andplot_lines()callsrotate_and_scale_lines()withflip=True. Instead supplyingflip=flip, in conjunction with the previous point, fixes both of my problems.According to
git blame, these two occurrences offlip=Truehave been present for quite a while. Given this and the lack of issues or pull requests relating to the problems I encountered, I'm not sure if this is actually wrong or if something on my side is set up incorrectly.