BAEL-9469 Accept maxAttempts(0) #18867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor retry policy to use builder pattern and add a new bean for testing maxAttempts(0) functionality.
Added a new test case to verify behavior when maxAttempts is set to 0, ensuring no retries occur.
Added reactive retry service and recovery method for reactive types.
Added a reactive implementation for retry service with a recovery method.
Removed reactor-core dependency from pom.xml
Removed reactive retry service and its recover method.
KevinGilmore
requested changes
Oct 17, 2025
Collaborator
KevinGilmore
left a comment
There was a problem hiding this comment.
See notes regarding whitespace-only changes (revert them) and the comment lines that aren't necessary.
|
|
||
| @Autowired | ||
| private RetryTemplate retryTemplate; | ||
| // Autowire the new template configuration |
Collaborator
There was a problem hiding this comment.
comment not necessary
| }); | ||
| } | ||
|
|
||
| // **New test case for maxAttempts(0) - no retry should occur** |
Collaborator
There was a problem hiding this comment.
comment not necessary - the method name explains its purpose
|
|
||
| import java.sql.SQLException; | ||
|
|
||
Collaborator
There was a problem hiding this comment.
avoid whitespace-only changes in PRs
Contributor
Author
There was a problem hiding this comment.
fixed. please verify.
| @Recover | ||
| void recover(SQLException e, String sql); | ||
|
|
||
Collaborator
There was a problem hiding this comment.
avoid whitespace-only changes in PRs
Contributor
Author
There was a problem hiding this comment.
fixed. please verify.
| logger.info("throw RuntimeException in method templateRetryService()"); | ||
| throw new RuntimeException(); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
avoid whitespace-only changes in PRs
Refactor SpringRetryIntegrationTest to autowire new template configuration and clean up comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.