BAEL-8530: Introduction to Netty-SocketIO #18722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazzer
commented
Aug 1, 2025
| private static final Logger LOG = LoggerFactory.getLogger(ServerLiveTest.class); | ||
|
|
||
| @Test | ||
| void startServer() throws Exception { |
Contributor
Author
There was a problem hiding this comment.
I've written this as a live test, but it's not really a test. It's just a convenient way to run the server code.
sazzer
commented
Aug 1, 2025
|
|
||
| server.start(); | ||
|
|
||
| Thread.currentThread().join(); |
Contributor
Author
There was a problem hiding this comment.
This is needed otherwise the method immediately ends and the server stops.
sazzer
commented
Aug 1, 2025
Contributor
Author
There was a problem hiding this comment.
This is a sample HTML file that uses the Socket.IO JavaScript library to connect to the server.
theangrydev
requested changes
Aug 1, 2025
Comment on lines
29
to
31
| server.addDisconnectListener(client -> { | ||
| LOG.info("Disconnection from client {}", client.getRemoteAddress()); | ||
| }); |
Collaborator
There was a problem hiding this comment.
Should we demo the client leaving the room here, or that is automatic?
Contributor
Author
There was a problem hiding this comment.
It's automatic when a client disconnects that they are removed from any rooms they're in. I've mentioned this in the article now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.