BAEL-9305 #18668
Merged
BAEL-9305 #18668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theangrydev
requested changes
Jul 11, 2025
| @Autowired | ||
| private TestOrderRepository orderRepository; | ||
|
|
||
| @Transactional //<-- marks this method |
Collaborator
There was a problem hiding this comment.
Suggested change
| @Transactional //<-- marks this method | |
| @Transactional |
I think we should omit this, usually the guideline is to describe in the article rather than in comments
| import jakarta.persistence.Id; | ||
| import jakarta.persistence.Table; | ||
|
|
||
| import lombok.Getter; |
Collaborator
There was a problem hiding this comment.
We have a guideline to not use Lombok in articles that aren't specifically demonstrating Lombok features
|
|
||
| @Test | ||
| void givenPublicTransactionalMethod_whenCallingIt_thenShouldRollbackOnException() { | ||
| assertThat(testOrderRepository.findAll()).isEmpty(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| assertThat(testOrderRepository.findAll()).isEmpty(); | |
| assertThat(testOrderRepository.findAll()) | |
| .isEmpty(); |
Let's format the chained method calls on separate lines to make them more visible
Contributor
Author
There was a problem hiding this comment.
Is this really the right way? I applied the Baeldung code style which, after I added line break like you suggested, corrected it back to the way it is now.
There was a problem hiding this comment.
@LeoHelfferich from the author guidelines:
formatting - fluent APIs
- sometimes, the default formatter does need a bit of manual help
- for example, fluent APIs are more readable if we split each method call on its own line
- if the method call is small enough, and very logically connected to the next one - you can also group 2 on a single line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.