Testing with Mapstruct Mappers #18625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
22
to
24
| MediaService testee = new MediaService(mockMediaMapper); | ||
| MediaDto mediaDto = new MediaDto(1L, "title 1"); | ||
| Media persisted = testee.persistMedia(mediaDto); |
Collaborator
There was a problem hiding this comment.
Let's put a blank line before and after this group of lines.
Comment on lines
26
to
27
| assertEquals(persisted.getId(), mockedMedia.getId()); | ||
| assertEquals(persisted.getTitle(), mockedMedia.getTitle()); |
Collaborator
There was a problem hiding this comment.
Reverse order of arguments - should be assertEquals(expected, actual)
Comment on lines
26
to
27
| assertEquals(persisted.getId(), mediaDto.getId()); | ||
| assertEquals(persisted.getTitle(), mediaDto.getTitle()); |
Comment on lines
36
to
37
| assertEquals(persisted.getId(), mockedMedia.getId()); | ||
| assertEquals(persisted.getTitle(), mockedMedia.getTitle()); |
|
|
||
| @Test | ||
| public void whenGeneratedMapperIsUsed_thenActualValuesAreMapped() { | ||
| MediaService testee = new MediaService(Mappers.getMapper(MediaMapper.class)); |
Collaborator
There was a problem hiding this comment.
Let's just call it mediaService (not testee). Same for other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.