Update pom.xml #18537
Merged
Update pom.xml #18537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<skip>true</skip> tells the plugin to bypass both compilation and execution of its J2CL tests, so the missing test_summary.json error disappears and the rest of your multi-module build keeps running its normal unit / integration tests.
A project with packaging pom is not required to produce a primary JAR/WAR artefact, so Maven’s package phase won’t expect the maven-war-plugin at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"skip true" tells the plugin to bypass both compilation and execution of its J2CL tests, so the missing test_summary.json error should disappear and the rest of the multi-module build should keep running its normal unit / integration tests.
A project with packaging pom is not required to produce a primary JAR/WAR artefact, so Maven’s package phase won’t expect the maven-war-plugin at all.