Bael 7230 modify properties #18519
Merged
Bael 7230 modify properties #18519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* small refactoring on all changes
70bc93b to
b2060dd
Compare
KevinGilmore
reviewed
May 4, 2025
Comment on lines
21
to
26
| <version>2.11.0</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>commons-beanutils</groupId> | ||
| <artifactId>commons-beanutils</artifactId> | ||
| <version>1.10.1</version> |
Collaborator
There was a problem hiding this comment.
Let's use properties for all version numbers as per guidelines
KevinGilmore
reviewed
May 4, 2025
Comment on lines
36
to
47
| public void addProperty_whenApacheCommonsIsUsed_thenReturnsNewPropertyWithoutAffectingOtherProperties() throws ConfigurationException { | ||
| assertNull(propertyMutator.getProperty("new.property")); | ||
| assertEquals("TestApp", propertyMutator.getProperty("name")); | ||
|
|
||
| propertyMutator.addProperty("new.property", "new-value"); | ||
|
|
||
| assertEquals("new-value", propertyMutator.getProperty("new.property")); | ||
| assertEquals("TestApp", propertyMutator.getProperty("name")); | ||
| } | ||
|
|
||
| @Test | ||
| public void updateProperty_whenApacheCommonsIsUsed_thenReturnsUpdatedPropertyWithoutAffectingOtherProperties() throws ConfigurationException { |
Collaborator
There was a problem hiding this comment.
In this file and the other unit test files, let's stick to the [givenX_]whenY_thenZ pattern rather than prefixing the test names. Here are a couple of example naming conventions you might use, given the first test as an example:
- whenAddPropertyUsingApacheCommons_then...
- givenApacheCommons_thenAddProperty_then...
Contributor
Author
There was a problem hiding this comment.
thanks @KevinGilmore
i'm always carried away and use uncle bob's rule of test method name first 😬
Collaborator
|
retest this please (force jenkins rebuild) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.