Demonstrate establishment of new connections by HttpClient on exceptions ... #18435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* + minor improvements
…ons during interactions with server (JavaHttpClientExceptionHandlingUnitTest). * including: - added file appender config for logback for unit-testing assertions & tweak levels (logback.xml) - added suite (for sequencing) (JavaHttpClientTestSuite.java) - updated source, dependencies & testing config (pom.xml)
… last commit on this branch * thus resolving the following error: - [ERROR] /var/lib/jenkins/workspace/tutorials-build-pr/core-java-modules/core-java-httpclient/src/main/java/com/baeldung/rest/RestApiServer.java:[20,24] switch rules are not supported in -source 11 (use -source 14 or higher to enable switch rules)
15f15dc to
ac6bd5c
Compare
* executing the others directly - as sequencing is only needed for tests affecting WireMock logging
* to ensure that concurrent WireMock logging doesn't take place - even if surefire-based TestSuite config is ignored
* for exception handling testing - using file size threshold instead of fixed delay or TestSuite
Collaborator
|
Hi @haqer1 Is this related to a Jira or other issue? Thanks. |
Contributor
Author
Collaborator
|
Thanks @haqer1 This seems to showcase new content, rather than a problem in the existing code. Our process for adding new code is more extensive, because we would have to continue maintaining it. I will close the PR and the new GitHub issue. Thanks. |
Contributor
Author
|
Yes, it's not about bug in existing code. Strange: it's useful info & code that many people don't know & would benefit from knowing, with automated tests, including interesting stuff for assertions. Why not merge this? What else would be needed according to your "more extensive process"? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… during interactions with server (JavaHttpClientExceptionHandlingUnitTest).