[BAEL-6548] Determine empty row in Microsoft Excel #17479
Conversation
| try (FileInputStream file = new FileInputStream(fileLocation); ReadableWorkbook wb = new ReadableWorkbook(file)) { | ||
| Sheet sheet = wb.getFirstSheet(); | ||
| try (Stream<Row> rows = sheet.openStream()) { | ||
| assertEquals(false, fastexcelHelper.isRowEmpty(rows.reduce((first, second) -> second).get())); |
There was a problem hiding this comment.
This reduce statement is a bit hard to understand
There was a problem hiding this comment.
I have changed it as per the review comments.
| import org.dhatim.fastexcel.reader.Row; | ||
|
|
||
| public class FastexcelHelper { | ||
| public boolean isRowEmpty(Row row) { |
There was a problem hiding this comment.
This is not formatted as per the standard. You're using tabs, where we should be using spaces.
| public class JExcelHelper { | ||
|
|
||
| public boolean isRowEmpty(Cell[] row) { | ||
| if (row == null) { |
There was a problem hiding this comment.
This is using a mixture of tabs and spaces
| import jxl.read.biff.BiffException; | ||
|
|
||
|
|
||
| public class JExcelDetectEmptyRowUnitTest { |
There was a problem hiding this comment.
Needs to be formatted as per the standard - this uses tabs
There was a problem hiding this comment.
Done, please check.
| @Before | ||
| public void loadExcelFile() throws IOException { | ||
|
|
||
| fileLocation = "src/main/resources/" + FILE_NAME; |
There was a problem hiding this comment.
This does not need to be initialized this way. fileLocation always has the same value and so should be private static final String FILE_LOCATION initialized in the class' static initializer list
| private static final String SHEET_NAME = "Sheet1"; | ||
|
|
||
| @Test | ||
| public void givenExcelFileWithXLSXFormat_whenGetColumnNames_thenReturnsColumnNames() throws IOException { |
| public void whenParsingFastExcelFile_thenDetectEmptyRow() throws IOException { | ||
| try (FileInputStream file = new FileInputStream(fileLocation); ReadableWorkbook wb = new ReadableWorkbook(file)) { | ||
| Sheet sheet = wb.getFirstSheet(); | ||
| try (Stream<Row> rows = sheet.openStream()) { |
There was a problem hiding this comment.
Why is this implementation not possible?
// assert all rows are empty
try (Stream<Row> rows = sheet.openStream()) {
boolean isEmpty = rows.allMatch(fastexcelHelper::isRowEmpty);
assertTrue(isEmpty);
}
// assert last row is empty
try (Stream<Row> rows = sheet.openStream()) {
Optional<Row> last = rows.reduce((first, second) -> second);
boolean isLastRowEmpty = last.map(fastexcelHelper::isRowEmpty).orElseThrow();
assertTrue(isLastRowEmpty);
}There was a problem hiding this comment.
Done, I added test cases for an empty file and a file with a few records but empty rows.
Added the code and tests for checking if the row is empty using the following libraries:
Test cases for each of the library with a file containing a few records and an empty file.