-
Notifications
You must be signed in to change notification settings - Fork 54k
BAEL-6572: Added mapping for id and test, based on review comment #14712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of modifying each existing test, add a new test just for the id field. In that test, set the id in the LicenseDto, then assert the same id is present in the License after mapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done but I have just validated that it's not null since the mapping is not based on licenseDto, as per my mapping example its populated with a random UUID as usually this will be decided during persistence. Please let me know if any comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which class are you suggesting would have the UUID automatically populated by the persistence layer, both the License and the LicenseDto?
In my mind, I thought that the LicenseDto was (as a Data Transfer Object) was the object that would be persisted, and the License is the domain object that is mapped to/from the LicenseDto.
The flow I would usually expect is:
- LicenseDto is saved to persistence layer, including an automatically generated UUID
- LicenseDto is later retrieved from the persistence layer
- LicenseDto is mapped to domain object License, keeping the same UUID
- License might later be modified due to some business rules
- License is mapped back to LicenseDto to be saved, keeping the same UUID
- LicenseDto is updated in the persistence layer, using the UUID as a key
Did you have something different in mind? What scenario is there when the License and LicenseDto would have a different automatically generated UUID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theangrydev Apologies for the confusion, its been a while I wrote this and I thought of something else but now realised mapper is different. Yes you are right, licenseDto is the input and we map it to domain object License so we will get Id from the licenseDto. I have modified the PR accordingly
theangrydev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed we did not remove Lombok for the License too - can you make this change too please? Lombok should not appear in the examples at all
theangrydev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed we did not remove Lombok for the License too - can you make this change too please? Lombok should not appear in the examples at all
No description provided.