BAEL-7166 Code for the Pass JVM arguments through Maven article #16860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2390281 to
a011e41
Compare
vinipx
reviewed
Jun 18, 2024
| private MockMvc mockMvc; | ||
|
|
||
| @Test | ||
| void whenGetWebsiteName_ThenBaeldung() throws Exception { |
Contributor
There was a problem hiding this comment.
minor but maybe we can polish the naming here?
whenGetWebsiteName_thenBaeldungIsDisplayed
or
whenGetWebsiteName_thenBaeldungIsReturned
Note: remember that _Then should be _then
| MyService myService = new MyService(); | ||
|
|
||
| @Test | ||
| void whenGetWebsiteName_thenBaeldung() throws NoSuchFieldException, SecurityException, IllegalArgumentException, IllegalAccessException { |
Contributor
There was a problem hiding this comment.
minor but maybe we can polish the naming here?
whenGetWebsiteName_thenBaeldungIsDisplayed
or
whenGetWebsiteName_thenBaeldungIsReturned
| private MockMvc mockMvc; | ||
|
|
||
| @Test | ||
| void whenGetLength_ThenZero() throws Exception { |
Contributor
There was a problem hiding this comment.
then - should be lower case
a011e41 to
c6b666c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.