BAEL-4967-Enterprise AWS Lambda Features #10799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KevinGilmore
left a comment
There was a problem hiding this comment.
See notes about indentation and placement of + operators
Comment on lines
31
to
32
| context.getLogger().log("Environment: " + | ||
| environmentName + "\n"); |
Collaborator
There was a problem hiding this comment.
bring the + operator down to the next line and indent only two spaces
Comment on lines
37
to
38
| .getOldestToDo() | ||
| .ifPresent(postService::makePost); |
Collaborator
There was a problem hiding this comment.
indentation - two spaces
Comment on lines
34
to
38
| return "PostItem{" + | ||
| "title='" + title + '\'' + | ||
| ", body='" + body + '\'' + | ||
| ", userId=" + userId + | ||
| '}'; |
Collaborator
There was a problem hiding this comment.
move the + operators at line end to the next line
Comment on lines
44
to
48
| "userId=" + userId + | ||
| ", id=" + id + | ||
| ", title='" + title + '\'' + | ||
| ", completed=" + completed + | ||
| '}'; |
Collaborator
There was a problem hiding this comment.
move trailing + operators down
Comment on lines
21
to
25
| .decoder(new GsonDecoder()) | ||
| .logger(new Slf4jLogger()) | ||
| .logLevel(FULL) | ||
| .requestInterceptor(new BasicAuthRequestInterceptor(config.getToDoCredentials().getUsername(), config.getToDoCredentials().getPassword())) | ||
| .target(ToDoApi.class, config.getToDoEndpoint()); |
Collaborator
There was a problem hiding this comment.
indent only two spaces
Comment on lines
28
to
32
| .encoder(new GsonEncoder()) | ||
| .logger(new Slf4jLogger()) | ||
| .logLevel(FULL) | ||
| .requestInterceptor(new BasicAuthRequestInterceptor(config.getPostCredentials().getUsername(), config.getPostCredentials().getPassword())) | ||
| .target(PostApi.class, config.getPostEndpoint()); |
Collaborator
There was a problem hiding this comment.
indent only two spaces
Comment on lines
27
to
28
| .filter(item -> !item.isCompleted()) | ||
| .findFirst(); |
| new App().handleRequest(fakeInputStream, fakeOutputStream, mockContext); | ||
|
|
||
| verify(mockContext.getLogger()) | ||
| .log("Environment: unitTest\n"); |
| @Test | ||
| public void givenEnvironmentVariableIsNotSet_thenUseDefault() { | ||
| String setting = Optional.ofNullable(System.getenv("SETTING")) | ||
| .orElse("default"); |
| ToDoReaderService service = new ToDoReaderService(config, null); | ||
|
|
||
| assertThat(systemOutRule.getLinesNormalized()) | ||
| .contains("ToDo Endpoint on: https://todo-endpoint.com"); |
f6c58b7 to
496a895
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.