-
Notifications
You must be signed in to change notification settings - Fork 160
Open
Description
I tried to fill the tests (with -m not slow
) and there's some tests that now fail due to the gas limit reduction:
- tests/static/state_tests/stCreateTest/createLargeResultFiller.yml
- tests/static/state_tests/stEIP1559/baseFeeDiffPlacesFiller.yml
- tests/static/state_tests/stEIP1559/gasPriceDiffPlacesFiller.yml
- tests/static/state_tests/stEIP1559/outOfFundsFiller.yml
- tests/static/state_tests/stEIP1559/outOfFundsOldTypesFiller.yml
- tests/static/state_tests/stRevertTest/costRevertFiller.yml
- tests/static/state_tests/stShift/shiftSignedCombinationsFiller.yml
- tests/static/state_tests/VMTests/vmIOandFlowOperations/gasFiller.yml
- tests/static/state_tests/VMTests/vmIOandFlowOperations/msizeFiller.yml
I fixed two in the last two commits to get things started:
- Skip tstore ddos tests skips tests in 15_tstoreCannotBeDosdFiller.yml and 21_tstoreCannotBeDosdOOOFiller.yml due to them now being addressed in the benchmark tests
tests/benchmark/test_worst_compute.py::test_worst_tstore
, but I had to create an issue to track a simple update that has to be made to the test in order to fully cover what the static tests were doing. - Split CREATE2_FirstByte_loopFiller.yml modifies CREATE2_FirstByte_loopFiller.yml to be split in three transactions in order to keep the gas limit below the new max, and keep the test verification working.
PTAL at those two examples, and I think the rest of the failing tests also need to be fixed with either of these two methods.
Originally posted by @marioevz in #1924 (comment)
Metadata
Metadata
Assignees
Labels
No labels