Server-side support for enhanced status codes #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Apr 14, 2019
RFC 3463 is just codes, RFC 2034 defines actual extension.
Per RFC 2034 we must include a code, but some backends may not support it, so provide a generic fallback.
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 63.42% 62.73% -0.69%
==========================================
Files 6 6
Lines 678 695 +17
==========================================
+ Hits 430 436 +6
- Misses 184 192 +8
- Partials 64 67 +3
Continue to review full report at Codecov.
|
Collaborator
Author
|
As for client support, I decided to leave it for another time because we don't return status codes in client functions at all. |
emersion
reviewed
Apr 16, 2019
emersion
reviewed
Apr 16, 2019
data.go
Outdated
| Code int | ||
| Message string | ||
| Code int | ||
| EnhancedCode [3]int |
Owner
There was a problem hiding this comment.
Could we have a special EnhancedCode type, so that it's easier to spot constants?
emersion
reviewed
Apr 16, 2019
emersion
reviewed
Apr 16, 2019
Owner
|
LGTM otherwise! |
emersion
approved these changes
Apr 16, 2019
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.