Improved error handling #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxcpp
reviewed
Aug 11, 2020
corny
approved these changes
Aug 11, 2020
emersion
reviewed
Aug 11, 2020
foxcpp
reviewed
Sep 13, 2020
Now matches the 500 code thrown by protocolError
Contributor
Author
|
@foxcpp Should be all good to go now 🎉 |
Collaborator
|
Thanks! |
This was referenced Sep 13, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests makes error handling a little more consistent and fixes issue #71. Pull request #72 has been open to address this issue for a while but without much sign of life from the author. This change