这是indexloc提供的服务，不要输入任何密码
Skip to content

Allow setting lookup DNS/TXT function #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2020
Merged

Allow setting lookup DNS/TXT function #26

merged 3 commits into from
Apr 29, 2020

Conversation

@huicao
Copy link
Contributor

@huicao huicao commented Apr 13, 2020

Change-Id: I752ca137cb14fb1575105611453511ffa2d92a9c

Allow setting lookup DNS/TXT function
167f45a 
Change-Id: I752ca137cb14fb1575105611453511ffa2d92a9c
@huicao
Copy link
Contributor Author

huicao commented Apr 13, 2020

This addressed the comments from foxcpp.

@huicao
Copy link
Contributor Author

huicao commented Apr 17, 2020

Hi Simon,
Can you review this pull request? I want to use it in my system.
Thanks,
Hui.

@foxcpp
Copy link
Contributor

foxcpp commented Apr 17, 2020

You can use your own fork for now by using replace in go.mod:

replace github.com/emersion/go-msgauth => github.com/huicao/go-msgauth 167f45a791ff1789575786f0f035916502447c28

emersion
emersion reviewed Apr 22, 2020
View reviewed changes
emersion
emersion reviewed Apr 22, 2020
View reviewed changes
emersion
emersion reviewed Apr 22, 2020
View reviewed changes
emersion
emersion reviewed Apr 22, 2020
View reviewed changes
emersion
emersion requested changes Apr 22, 2020
View reviewed changes
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, here are a few comments

Add comments and add options for dmarc lookup
e2f1059 
Change-Id: I93c16631e8afc3804cd9771b7d25f5e3ab71e73d
@huicao huicao requested a review from emersion April 25, 2020 17:11
@foxcpp
Copy link
Contributor

foxcpp commented Apr 29, 2020 •
edited
Loading

Hey, @emersion, can we get this merged? Just got a pile of DATA RACE warnings in maddy tests on CI because DKIM test modifies net.DefaultResolver.

emersion
emersion requested changes Apr 29, 2020
View reviewed changes
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from these minor issues, LGTM

emersion
emersion reviewed Apr 29, 2020
View reviewed changes
Reformat the comments for consistence
f7e2676 
Change-Id: I21ff548ed27072761b891570e1c96301ee63dfde
emersion
emersion approved these changes Apr 29, 2020
View reviewed changes
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@emersion emersion merged commit af2e579 into emersion:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emersion emersion emersion approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huicao @foxcpp @emersion