Allow setting lookup DNS/TXT function #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 15, 2019 11:49
Change-Id: I0e023a602004bb18f573321c5811d1c876312663
Change-Id: Id23c3a5f168214f441268e582d6448ab57defa12
Change-Id: I299ac0c11aac1dda96c6637e2590413518972a1e
Change-Id: I19519a0a10289aa770156ca4ebfc8ce3b20c4a35
Change-Id: I5f77d2c52ace909fb18696492b9c4c6ce3ed5e57
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 66.50% 66.34% -0.17%
==========================================
Files 7 7
Lines 827 829 +2
==========================================
Hits 550 550
- Misses 208 210 +2
Partials 69 69
Continue to review full report at Codecov.
|
Contributor
foxcpp
reviewed
Apr 11, 2020
Contributor
foxcpp
left a comment
There was a problem hiding this comment.
Global variable seems to be a quick hack. I think having a VeriifyOptions structure similar to SignOptions is more useful and clean.
Contributor
Author
|
I agree. Would you mind to bring up your patch again? I think this is very useful. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change can allow us cache the record to minimize latency