Add HeaderFields.Len #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
requested changes
Apr 29, 2020
Owner
emersion
left a comment
There was a problem hiding this comment.
LGTM apart from the doc nits.
Can you also squash the change into a single commit?
textproto/header.go
Outdated
| // | ||
| // The header may not be mutated while iterating, except using HeaderFields.Del. | ||
| // The header may not be mutated while iterating, except using HeaderFields.Del | ||
| // and HeaderFields.Set. |
Owner
There was a problem hiding this comment.
This line should not be changed.
Collaborator
Author
There was a problem hiding this comment.
woops, forgot to remove that one
textproto/header.go
Outdated
| // | ||
| // The header may not be mutated while iterating, except using HeaderFields.Del. | ||
| // The header may not be mutated while iterating, except using HeaderFields.Del | ||
| // and HeaderFields.Set. |
Owner
There was a problem hiding this comment.
This line should not be changed.
22ebc87 to
93490e2
Compare
Collaborator
Author
|
git, what you have done! |
93490e2 to
c0ff7ae
Compare
c0ff7ae to
1580415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #75.