这是indexloc提供的服务，不要输入任何密码
Skip to content

mail: add msg-id setters #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2020
Merged

mail: add msg-id setters #72

merged 2 commits into from
Aug 24, 2020

Conversation

@emersion
Copy link
Owner

@emersion emersion commented Feb 15, 2020

See each commit.

Should we add SetMessageID, or wait till someone needs it?

cc @foxcpp

@emersion
mail: replace GenerateMessageID with Header.GenerateMessageID
eca9b69 
This allows us to hide the brackets logic away from the library users.

While at it, check rand.Read's return value and make the function
return an error when applicable.

The test is changed to use our Message-Id parser to check the generated
value instead of the regexp.
@emersion
mail: add Header.SetMsgIDList
3d8661a
@foxcpp
Copy link
Collaborator

foxcpp commented Feb 15, 2020

Should we add SetMessageID, or wait till someone needs it?

If it is SetMessageID(id string), then it is not a big deal since it would be literally h.Set("Message-ID", "<" + id + ">"). In fact, I think most users that need it will miss our amazing helper function and just do h.Set!

@emersion
Copy link
Owner Author

emersion commented Feb 15, 2020 •
edited
Loading

Indeed. Header.SetMsgIDList is more helpful since most people would separate each msg-id with a comma instead of a space. It also allows users to easily parse, add a new msg-id, and format a References field.

@emersion emersion mentioned this pull request Jun 21, 2020
Closed
@emersion emersion merged commit 5cde435 into master Aug 24, 2020
@emersion emersion deleted the msg-id-setters branch August 24, 2020 20:51
@emersion emersion added the breaking Breaking change label Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking Breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emersion @foxcpp