textproto: Add limits for header field length and total amount of fields #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limits specified allow header sections with total size up to ~3.8 MiB. This should be enough for literally any message.
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=========================================
- Coverage 80.2% 80.1% -0.11%
=========================================
Files 15 15
Lines 980 995 +15
=========================================
+ Hits 786 797 +11
- Misses 119 122 +3
- Partials 75 76 +1
Continue to review full report at Codecov.
|
emersion
reviewed
Feb 15, 2020
emersion
reviewed
Feb 15, 2020
emersion
reviewed
Feb 15, 2020
Owner
emersion
left a comment
There was a problem hiding this comment.
Looks good otherwise, nice addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits specified allow header sections with total size up to ~3.8 MiB.
This should be enough for literally any message.
Closes #28.
Related to foxcpp/maddy#118.