Codecov Report

Merging #66 into master will increase coverage by 0.02%.
The diff coverage is 63.63%.

@@           Coverage Diff           @@
##           master   #66      +/-   ##
=======================================
+ Coverage   61.98%   62%   +0.02%     
=======================================
  Files          15    15              
  Lines         847   858      +11     
=======================================
+ Hits          525   532       +7     
- Misses        278   280       +2     
- Partials       44    46       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e6e18...6708900. Read the comment docs.

Can we make kv a byte slice?

Can we make kv a byte slice?

I do not see any reason to use []byte over string, but whatever. Done.

I do not see any reason to use []byte over string, but whatever. Done.

I should've explained my rationale se we can discuss:

• []byte makes it clearer users shouldn't generally use this function because it doesn't handle line wrapping
• []byte ties this function to the wire format (io.Reader) rather than the parsed data
• Minor: []byte allows to save one allocation