Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   61.37%   61.37%           
=======================================
  Files          16       16           
  Lines         844      844           
=======================================
  Hits          518      518           
  Misses        280      280           
  Partials       46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85cd354...8073d27. Read the comment docs.

Are these really used in practice? I've tried to keep the number of charsets down to mitigate the binary size.

@emersion yes actually :D i use your go-message lib in mail2most and some of the users reported problems when getting different emails. With the character encoding at least 3 of them i have been able to reproduce so i choosed to add them all. Here is the link to the m2m issue

@emersion anything to do here ?

any chance to get this merged ?

I'd prefer not to do add all of these. Please only add those encountered in the wild.

The default set in go-message is supposed to parse most messages, but will never be able to parse all of them. Note, you can register additional go-message charsets in your app if needed.

@emersion ah i missed the func RegisterEncoding(name string, enc encoding.Encoding) function thats a very good point indeed. I added the missing charsets using this method so there is no need to merge this PR anymore if you dont want it. Thanks for your help.