Support iso-8859-1 encoding #180
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@emersion I added a list of popular encodings. In that way we can parse emails a lot easier. Can you take a look? 🙏 |
Owner
|
The way the library is designed, by default no encodings are included so that the library doesn't result in a much bigger binary size. Users can opt-in to import common encodings. See https://pkg.go.dev/github.com/emersion/go-message#pkg-overview |
Author
|
Thank you @emersion ! I just tested and it works. PR is closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @emersion ,
Can I add support to iso-8859-1 encoding? I saw this encoding is supported in
charset.go, but notencoding.go: https://github.com/emersion/go-message/blob/master/charset/charset.go#L27I am fairly new to this library. Please let me know if I need to make more changes to support iso-8859-1.
ps: Can I add some more encodings? I can do it as part of this PR.
Thank you.
Zhi Qu