Add function to set Message-ID hostname manually #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually the hostname of the local machine tends to be not unique nor a FQDN. This brings multiple problems with it when sending messages using such Message-ID. First of all this makes go-message more compliant to RFC5322 [1] because it recommends to use a FQDN on the right handed side of the @ in the Message-ID. Second this also improves the situation with spam filters, because some of them (for example rspamd) give a bad score for messages without a FQDN in the Message-ID. [1] https://www.rfc-editor.org/rfc/rfc5322.html#section-3.6.4
Contributor
Author
|
@emersion anything I need to do here, to get a review or at least a comment on my PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually the hostname of the local machine tends to be not unique nor a
FQDN. This brings multiple problems with it when sending messages using
such Message-ID.
First of all this makes go-message more compliant to RFC5322 [1] because
it recommends to use a FQDN on the right handed side of the @ in the
Message-ID. Second this also improves the situation with spam filters,
because some of them (for example rspamd) give a bad score for messages
without a FQDN in the Message-ID.
[1] https://www.rfc-editor.org/rfc/rfc5322.html#section-3.6.4