v2: initial implementation #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to register the command before endCommand: literals are sent before the command's final CRLF. When the server refuses a literal, it fails the whole command.
This makes it way clearer who's responsible for ending the command.
Owner
Author
|
Alright, I think this is a good starting point. Let's merge this and continue the work on the v2 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FetchCommandchannel not closed)FetchItemDataSectionLoggedOutchannel)FetchItemData{Body,Binary}Section.SectionCOPYUIDin response toMOVEcommandLITERAL-