code review #303
Closed
code review #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icantly more efficient
… updater is a better name
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
+ Coverage 73.05% 73.07% +0.02%
==========================================
Files 32 32
Lines 3462 3465 +3
==========================================
+ Hits 2529 2532 +3
Misses 641 641
Partials 292 292
Continue to review full report at Codecov.
|
emersion
requested changes
Oct 19, 2019
Owner
emersion
left a comment
There was a problem hiding this comment.
This PR contains breaking changes. Please remove them.
Collaborator
|
This PR can be a candidate for merge in v2. |
Owner
|
Closing because this is superseded by go-imap v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some code review with help of static analysis and refactored some parts.