feat: webFrameMain.fromFrameToken #47850
Open
+55
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dsanders11
approved these changes
Jul 22, 2025
Comment on lines
+75
to
+76
| Returns `WebFrameMain | undefined` - A frame with the given process and frame token, | ||
| or `undefined` if there is no WebFrameMain associated with the given IDs. |
There was a problem hiding this comment.
Suggested change
| Returns `WebFrameMain | undefined` - A frame with the given process and frame token, | |
| or `undefined` if there is no WebFrameMain associated with the given IDs. | |
| Returns `WebFrameMain | null` - A frame with the given process and frame token, | |
| or `null` if there is no WebFrameMain associated with the given IDs. |
Not blocking, but we had some discussion on Slack regarding undefined vs null for these kinds of APIs and I think consensus was heading towards returning null for the not found case.
10 tasks
erickzhao
reviewed
Jul 24, 2025
| ### `webFrameMain.fromFrameToken(processId, frameToken)` | ||
|
|
||
| * `processId` Integer - An `Integer` representing the internal ID of the process which owns the frame. | ||
| * `frameToken` string - A `string` representing the unique frame token in the |
There was a problem hiding this comment.
docs: i like the additional description we have on the webFrame.findFrameByToken API description:
Frame tokens can be retrieved from WebFrame instances (webFrame.frameToken) and can also be retrieved from WebFrameMain instances using webFrameMain.frameToken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Follow up to #47616
Adds
webFrameMain.fromFrameToken(processId, frameToken)which should be the defacto method of looking up frames based on the current chromium architecture.Checklist
npm testpassesRelease Notes
Notes: Added
webFrameMain.fromFrameToken(processId, frameToken)to get aWebFrameMaininstance from its frame token.