Update esbuild version to latest for keeping unknown directives during bundle #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this snapshot updated because of esbuild update: evanw/esbuild@b86e581
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: esbuild@0.17.6 |
Contributor
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Nextjs 13 app folder will use RSC by default, for lib author we need to add 'use client' directive on the top of bundle file, but older version of esbuild will filter all the unknown directives:
This PR upgrade esbuild to latest version(more info here) and add a new test for 'use client' directives.
And another side, this PR update one snapshot as well, because of this change from esbuild.
I think this PR can close #835 as well, please feel free to give feedback, thx