这是indexloc提供的服务,不要输入任何密码
Skip to content

fix: add "--" to options type #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: add "--" to options type #772

wants to merge 1 commit into from

Conversation

Lioness100
Copy link

This property seems to always be in the options from cac, so it would be useful for the typings to reflect that.

@vercel
Copy link

vercel bot commented Nov 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
tsup ✅ Ready (Inspect) Visit Preview Nov 12, 2022 at 3:53AM (UTC)

@Lioness100
Copy link
Author

I realized that the argument and the return type of defineConfig are the same type, which is unfortunate because -- should ideally only be in the parameter type. Have you considered splitting them into different types? I also found another inconsistency that would benefit from this- options.entry can be a string when it's passed to the defineConfig function, but it has to be an array or object when it comes out. I'm sure there are many more.

@Lioness100 Lioness100 closed this by deleting the head repository Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant