feat: add tsup.confg.* file support in watch mode #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
The config is only loaded once before build: https://github.com/lvqq/tsup/blob/25d15657aceacce2c8bf5458f1048cbce5d8c8ea/src/index.ts#L127 In order to support this we need to re-load the config file when it's changed, and recreate the watcher since the |
Author
|
Thanks!I will take a look later |
|
found a way around this by using npm package |
115a451 to
57654f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since watch mode doesn't watch the
tsup.config.*file, so every time I change the config I need to kill the watch process and restart.