clarify documentation regarding clean option
#746
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed [via code inspection] that specifying `clean: true` does not remove `*.d.ts` files by default, which was unexpected to me. This updates the documentation for this option to clarify that.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
it actually removes your Line 120 in 48b3381 |
|
Oh interesting. For some reason that isn't working for me, I will debug further. |
|
OK, it seems like the issue is that I am not using |
|
Perhaps the |
gavinsharp
added a commit
to gavinsharp/tsup
that referenced
this pull request
Oct 18, 2022
See egoist#746 for my initial confusion. I generate my types through a separate process (manual `tsc` invocation), and was confused when `clean: true` was not removing them when running tsup.
|
Not relevant after #747 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed via code inspection that specifying
clean: truedoes not remove*.d.tsfiles by default, which was unexpected to me. This updates the documentation for this option to clarify that.