Fix a race between dts clean and generate #767
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rollup's `buildStart` hook runs in parallel - see https://github.com/rollup/rollup/blob/master/docs/05-plugin-development.md#buildstart As described in their "build hooks" section, `parallel` hooks "will be run in the specified plugin order. If a hook is async, subsequent hooks of this kind will be run in parallel and not wait for the current hook." Since `buildStart` is parallel and we hadn't specified `sequential: true` or `order: xxx`, this plugin's `buildStart` hook could get run at the same time as other `buildStart` hooks. This caused a race condition when generating `.d.ts` files, and caused TSC errors consistently every other run of `tsup`. This commit ensures that the clean plugin will always run before the `.d.ts` generation step, preventing the race.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This doesn't seem to fix the issue when running |
|
After further investigation - this is not a TSUP bug, this is caused by a dependency cycle between two packages. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup's
buildStarthook runs in parallel - see https://github.com/rollup/rollup/blob/master/docs/05-plugin-development.md#buildstart As described in their "build hooks" section,parallelhooks "will be run in the specified plugin order. If a hook is async, subsequent hooks of this kind will be run in parallel and not wait for the current hook."Since
buildStartis parallel and we hadn't specifiedsequential: trueororder: xxx, this plugin'sbuildStarthook could get run at the same time as otherbuildStarthooks. This caused a race condition when generating.d.tsfiles, and caused TSC errors consistently every other run oftsup.This commit ensures that the clean plugin will always run before the
.d.tsgeneration step, preventing the race.