Improve conditional config example #514
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably pedantic, but from my understanding `minify: true` is actually faster in esbuild, and disabling it in watch mode is probably not what most users will want. Maybe there’s another, better, optional config example but I thought I’d open this as a starting point for that discussion.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/egoist/tsup/87CkHRa3HfebupXo4383bxJ82ooK |
115a451 to
57654f6
Compare
|
According to the context, this example says: The configuration can be changed based on CLI flags. In this example, it's important to emphasize the use of CLI flags over a possibly common usage scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably pedantic, but from my understanding
minify: trueis actually faster in esbuild, and disabling it in watch mode is probably not what most users will want.Maybe there’s another, better, optional config example but I thought I’d open this as a starting point for that discussion.