这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: pass sourcemap into Rollup treeShakingPlugin #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: pass sourcemap into Rollup treeShakingPlugin #890

wants to merge 1 commit into from

Conversation

@aleclarson
Copy link

@aleclarson aleclarson commented Apr 21, 2023

Fixes #889

@codesandbox
Copy link

codesandbox bot commented Apr 21, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Apr 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tsup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 9:52pm

@aleclarson
Copy link
Author

aleclarson commented Apr 21, 2023

Hmm, still not producing correct sourcemaps...

Could be something to do with:

tsup/src/plugin.ts

Lines 156 to 166 in 322cb77

if (result.map) {
const originalConsumer = await new SourceMapConsumer(
parseSourceMap(info.map)
)
const newConsumer = await new SourceMapConsumer(
parseSourceMap(result.map)
)
const generator =
SourceMapGenerator.fromSourceMap(originalConsumer)
generator.applySourceMap(newConsumer, info.path)
info.map = generator.toJSON()

…or maybe it's a Rollup bug?

@hyrious hyrious mentioned this pull request Jul 12, 2023
Closed
@xia0hj xia0hj mentioned this pull request Dec 28, 2023
Merged
@sxzz sxzz force-pushed the dev branch 2 times, most recently from 115a451 to 57654f6 Compare July 16, 2024 21:02
sxzz
sxzz previously approved these changes Jul 16, 2024
View reviewed changes
@sxzz sxzz dismissed their stale review July 16, 2024 21:59

Dismiss

@sxzz sxzz closed this in #1069 Jul 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024

🎉 This issue has been resolved in version 8.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sxzz sxzz sxzz left review comments

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sourcemaps break when using treeshake: 'smallest'

2 participants

@aleclarson @sxzz