fix: copyPublicDir in watch mode #1331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #831 by moving the
copyPublicDir
call inside thebuildAll
function. As a result, files from the public directory are now also copied whendebouncedBuildAll
is triggered (e.g., in watch mode).This introduces a potential breaking change:
Before:
onSuccess
was a function, it was always called beforecopyPublicDir
was even invoked.onSuccess
was a string, both the copy and the shell command were started simultaneously, leading to race conditions. In most cases, the copy finished first, but behavior was unreliableAfter this change:
onSuccess
is always called aftercopyPublicDir
completes — ensuring the build (including public files) is fully ready before executing any post-build logic.Potential improvements:
copyPublicDir
insidedebouncedBuildAll
only when options.clean is true. However, this may not be worth the added complexity: most public directories are probably small anddebouncedBuildAll
is already throttled. The current implementation is simpler and more predictable, which may outweigh this optimization.