feat: use fix-dts-default-cjs-exports to transform CJS types
#1310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sxzz
approved these changes
Feb 27, 2025
This was referenced Feb 28, 2025
|
Awesome work, I'd really appreciate a release with this one. Thanks in advance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted from this unbuild PR the logic to fix default CJS exports to this repository fix-dts-default-cjs-exports.
This PR using the Rollup plugin from the new repository replacing the current plugin here. Here unbuild PR to use the same Rollup plugin.
Looks like tsup, unbuild and pkgroll using rollup-plugin-dts.
Once this PR merged (🤞 🙏 ), I'll update the docs in my repository.
Check userquin/unbuild-cts-issue#2 and userquin/unbuild-cts-issue#3