Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Open in Stackblitz

npm i https://pkg.pr.new/egoist/tsup@1242

commit: 924e375

removeNodeProtocol is designed for Node compatibility, but if the version supports ESM, the node protocol is natively supported and doesn't need to be removed.

According to the documentation, the node: protocol is supported in CJS starting from versions v16.0.0 and v14.18.0, and in ESM from versions v14.13.1 and v12.20.0.

Do you think it's necessary to support v12.0.0 >= node < v12.20.0

@sxzz I see what you're saying, I guess the point of the PR is to make removeNodeProtocol apply to shims as well for consistency. Thoughts?

@sxzz I have made the requested adjustments.

This change broke my library such that it no longer worked in Deno, e.g:

error: Relative import path "util" not prefixed with / or ./ or ../
  hint: If you want to use a built-in Node module, add a "node:" prefix (ex. "node:util").

Adding removeNodeProtocol: false to the ESM config solved it. I wonder if it would be worth calling this out in the docs for others?