这是indexloc提供的服务,不要输入任何密码
Skip to content

chore: cut a new release #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 17, 2024
Merged

chore: cut a new release #1201

merged 5 commits into from
Sep 17, 2024

Conversation

ocavue
Copy link
Collaborator

@ocavue ocavue commented Sep 17, 2024

No description provided.

Copy link

codesandbox bot commented Sep 17, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tsup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 2:46am

Copy link

socket-security bot commented Sep 17, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/globby@11.1.0

View full report↗︎

@ocavue ocavue marked this pull request as ready for review September 17, 2024 03:03
@ocavue ocavue requested review from sxzz and egoist September 17, 2024 03:04
@egoist egoist merged commit ca7833b into main Sep 17, 2024
13 checks passed
@egoist
Copy link
Owner

egoist commented Sep 17, 2024

oops i should not release it from PR, the branches would not be in sync

CleanShot 2024-09-17 at 11 51 53@2x

@egoist
Copy link
Owner

egoist commented Sep 17, 2024

maybe we should move to a better release tool like changesets in the future

@sxzz
Copy link
Collaborator

sxzz commented Sep 17, 2024

@egoist Do you think bumpp + changelogithub is okay?
https://github.com/sxzz/ts-lib-starter/blob/main/.github/workflows/release.yml

@egoist
Copy link
Owner

egoist commented Sep 17, 2024

@egoist Do you think bumpp + changelogithub is okay? sxzz/ts-lib-starter@main/.github/workflows/release.yml

yeah that's nice, only thing that's missing is commenting on revelant PRs and issues, but i can live without it 👍

CleanShot 2024-09-17 at 12 26 09@2x

@sxzz
Copy link
Collaborator

sxzz commented Sep 17, 2024

@egoist We need to switch default branch to main

@egoist
Copy link
Owner

egoist commented Sep 17, 2024

@sxzz feel free to send a PR to add bumpp + changelogithub to main and change the default branch, if you can't change default branch i'll do that later

@sxzz
Copy link
Collaborator

sxzz commented Sep 17, 2024

I've push the commit to main branch without PR, but I have no permission to change the default branch.

@egoist
Copy link
Owner

egoist commented Sep 17, 2024

I've push the commit to main branch without PR, but I have no permission to change the default branch.

done

@sxzz sxzz deleted the dev branch September 17, 2024 05:23
@ocavue
Copy link
Collaborator Author

ocavue commented Sep 17, 2024

Just FYI, deleting dev branch closed all pending pull requests in this repo. It might not be a big deal since most of them haven't been approved for quite a while.

@sxzz sxzz restored the dev branch September 17, 2024 05:37
@sxzz
Copy link
Collaborator

sxzz commented Sep 17, 2024

Oh my bad...

@sxzz sxzz deleted the dev branch September 17, 2024 05:41
@sxzz
Copy link
Collaborator

sxzz commented Sep 17, 2024

@egoist Do you agree to add Renovate and pkg.pr.new to this repo? These apps require installation on the GitHub repository.

@egoist
Copy link
Owner

egoist commented Sep 17, 2024 via email

@sxzz
Copy link
Collaborator

sxzz commented Sep 17, 2024

@egoist
Copy link
Owner

egoist commented Sep 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants