这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@SuperchupuDev
Copy link
Contributor

@SuperchupuDev SuperchupuDev commented Jul 22, 2024

supersedes #1167, does basically the same but with globbing logic moved into its own library as suggested by maintainers

this is the followup pr mentioned in #1163. i've opened this mainly to get feedback from the maintainers on the best way to implement this. i can port the globbing code into its own package if needed, even though this isn't that much code

according to globby's readme the only exclusive features it has (that are relevant in this case) are negated patterns and directory expansion, which this pr both covers

the issues reported in 6.2.1 were all related to either me forgetting to handle negated patterns in entry or not knowing directory expansion was meant to be done. if there is any more globby-exclusive functionality missing let me know and i'll add it

i'd be happy to test any possible edge cases in the logic and add new tests

ref: #1163 (comment)

@codesandbox
Copy link

codesandbox bot commented Jul 22, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel
Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tsup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2024 10:06am

@socket-security
Copy link

socket-security bot commented Jul 22, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/globby@11.1.0, npm/typescript@5.5.4

View full report↗︎

@sxzz sxzz requested a review from egoist August 6, 2024 20:00
@sxzz sxzz merged commit 3f44303 into egoist:dev Aug 24, 2024
@SuperchupuDev SuperchupuDev deleted the no-globby-final-final-please branch August 24, 2024 10:53
egoist pushed a commit that referenced this pull request Sep 17, 2024
@github-actions
Copy link
Contributor

🎉 This PR is included in version 8.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants