fix: Replace parentPort.close() with process.exit() in worker thread #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that the worker thread signals the parent process to exit in the bun runtime environment. Previously, the parent process would continue running indefinitely due to an unclear issue with worker thread termination. This fix ensures a clean exit after the worker thread has completed its tasks.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
115a451 to
57654f6
Compare
Collaborator
|
Fixed by #1142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures the worker thread signals the parent process to exit in the bun runtime environment. Previously, the parent process would continue running indefinitely due to an unclear issue with worker thread termination. This fix ensures a clean exit after the worker thread has completed its tasks.
Context:
This bug stops us from fully migrating to the bun runtime for the Storybook mono repo without additional workarounds.
Reproduction:
Run tsup programmatically in a bun runtime instead of Node.js and define some DTS options so that the rollup worker thread spawns. With this fix, after building the DTS assets, the process exits successfully. Before, the process never exited.